Skip to content

[8.19] (backport #11184) Add support for all metricbeat input types #11459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: 8.19
Choose a base branch
from
Open

[8.19] (backport #11184) Add support for all metricbeat input types #11459

wants to merge 4 commits into from

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 27, 2025

What does this PR do?

This PR adds support for all metricbeat input types in OTel runtime by checking for suffix /metrics. This is a short term solution to enable testing

Why is it important?

To enable testing all input types

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

None

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...
This is an automatic backport of pull request #11184 done by [Mergify](https://mergify.com).

@khushijain21 @mergify
Add support for all metricbeat input types (#11184)
cc01175 
(cherry picked from commit 6d12db9)

# Conflicts:
#	internal/pkg/otel/translate/otelconfig.go
@mergify mergify bot requested a review from a team as a code owner November 27, 2025 08:33
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Nov 27, 2025
@mergify mergify bot requested review from michel-laterman and ycombinator and removed request for a team November 27, 2025 08:33
@mergify
Copy link
Contributor Author

mergify bot commented Nov 27, 2025

Cherry-pick of 6d12db9 has failed:

On branch mergify/bp/8.19/pr-11184
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit 6d12db919.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   internal/pkg/otel/translate/otelconfig.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog labels Nov 27, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 27, 2025

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

khushijain21
khushijain21 previously approved these changes Dec 1, 2025
View reviewed changes
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 1, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @khushijain21

@khushijain21
Copy link
Contributor

khushijain21 commented Dec 2, 2025

Requires #11522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khushijain21 khushijain21 khushijain21 left review comments

@ycombinator ycombinator Awaiting requested review from ycombinator ycombinator is a code owner automatically assigned from elastic/elastic-agent-control-plane

@michel-laterman michel-laterman Awaiting requested review from michel-laterman michel-laterman is a code owner automatically assigned from elastic/elastic-agent-control-plane

At least 1 approving review is required to merge this pull request.

Assignees

@khushijain21 khushijain21

Labels

backport conflicts There is a conflict in the backported pull request skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elasticmachine @khushijain21